Remove mean position during LNCI16#487
Merged
Merged
Conversation
ElliottKasoar
force-pushed
the
fix-lnci16
branch
from
July 17, 2026 18:05
ecff173 to
960f59b
Compare
Collaborator
Author
|
@joehart2001 I've tested this for a few different models (including polar models and it doesn't seem to change the values |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-review checklist for PR author
PR author must check the checkboxes below when creating the PR.
Summary
Removes mean positions of atoms for LNCI16, which is currently necessary to run high precision with mace-polar-1-l without memory issues on most devices, and increases the speed considerably too.
Testing
Tested on a 32 core EPYC 7502P. Still unable to run locally.
Further testing should be done to confirm other models are unchanged, but this didn't affect
mace-polar-1-m.